Announcement

Collapse
No announcement yet.

Git Commit Request For Components?

Collapse
X
  • Filter
  • Time
  • Show
Clear All
new posts

  • ttaber
    started a topic Git Commit Request For Components?

    Git Commit Request For Components?

    How would we go about requesting a commit to GitHub?

    I've noticed a few discrepancies in Components (both dev and master branch) when compared with v1.4.2 in Gestures.TouchGestures, Graphics3D.SkinnedModel, and Graphics3D.Model.

  • MarcosCobena
    replied
    Hi ttaber,

    Currently we push changes to GitHub when there's a minor release, so eventually there are differences like those you mention.

    Surely, we'll make a new push within a next release, so those branches will be updated again.

    Thanks for your help,

    Marcos

    Leave a comment:


  • ttaber
    replied
    In WaveEngine.Components.Gestures.TouchGestures it was just a matter of refactoring TouchOrdenChanged to TouchOrderChanged:

    In Model and SkinnedModel it was a single missing property between the two:
    WaveEngine.Components.Graphics3D.Model
    Code:
            /// <summary>
            /// Gets a value indicating whether this model has exported with collision information
            /// </summary>
           public override bool HasCollisionInfo
            {
                get
                {
                    if (this.InternalModel == null || this.InternalModel.Meshes == null || this.InternalModel.Meshes.Count <= 0)
                    {
                        return false;
                    }
                    return this.InternalModel.Meshes[0].HasCollision;
                }
            }
    WaveEngine.Components.Graphics3D.SkinnedModel
    Code:
            /// <summary>
            /// Gets a value indicating whether this model has exported with collision information
            /// </summary>
            public override bool HasCollisionInfo
            {
                get
                {
                    return false;
                }
            }
    Last edited by ttaber; 03-05-2015, 06:35 PM.

    Leave a comment:


  • AntonioAvila
    replied
    Hi ttaber?
    You can create a pull request and we will evaluate

    Anyway you can tell us what are the discrepancies that you've noticed

    Regards,
    Antonio

    Leave a comment:

Working...
X